Found a bug where the command breaks if testrunner.html is called with querystring parameters. The querystring is not chopped off the baseUrl before appending the include locator. To fix, I made the following change:

//Need to remove possible query string. Eg: testrunner.html?test=myTestSuite.html&auto=true
var docLoc = document.location;
docLoc = docLoc.href.substr(0, docLoc.href.length - docLoc.search.length);
baseUrl = docLoc.match(new RegExp("^(.+/)[^/]+$"))[1] // base uri = char - / - chars other than /

It's actually better to just update the regex.
baseUrl = document.URL.match(new RegExp("^([^?\n]+/).+$"))[1] // base uri = char - / - chars other than /

Is it more appropriate just to apply any fixes and update the attachment?

First of all, thanks Thoughtworks people for sharing a great UAT tool.

Second, some reports with the include command:

Got a bug when passing stored variables to the parameter list, e.g.

<tr><td>store</td><td>a001</td><td>nick</td>
<tr><td>include</td><td>tests/core/createAgent.html</td><td>name=${nick}, pwd=12345</td></tr>
}}}

Fix it: modify xpathExpr to accept anything in the third column instead of "text". ('cause all variables in "text" are replaced with stored values, hence "text" is no longer the same -> old xpathExpr failed).

New xpathExpr:

var xpathExpr = "//td/preceding-sibling::td[contains(text(),'" + locator + "')]/preceding-sibling::td[text()='include']/parent::tr"

Return if locateElementByXPath failed:
...
var includeCmdRow = PageBot.prototype.locateElementByXPath(xpathExpr, testDocument); //

if (!includeCmdRow) return
...

------------------------
MERRY X'MAS TO EVERYONE

Could someone please post an updated version of user-extensions.js.sample ? I've made the above changes and I'm still having issues.

Guillaume, I believe SVN Changeset above requires other changes as I'm getting a 'currentTest' is undefined error...

(Or if I'm completely wrong on this, and someone can correct me, I'd appreciate it).

Also, I haven't been able to track down the root cause, I'm seeing behaviour where nested includes (in my tests) work in Firefox, but not in IE (6.0.2800). (The tests included with the package do pass however...)

Thanks for the great work, this is a terrific extension to Selenium.. (previously I was using server-side includes to achieve the same results...)

Just spent some time trying to debug a problem with include command resulting in : "'document.URL.match(...).1' is null or not an object"

Actually this is because we were calling the tests without specifying any file name like http://localhost/qa/

It works if we call http://localhost/qa/index.html

It is also strange that we have to use ./path/testfile.html and not /path/testfile.html which will fail resulting in a "not found"

I have attached a patch against 0.6.0 containing the fixes mentioned above (http://wiki.openqa.org/display/SEL/include?focusedCommentId=326#comment-326
and http://wiki.openqa.org/display/SEL/include?focusedCommentId=352#comment-352)

as well as another fix I made which was to include support for tests located in subdirectories. That is, I had a URL like so:
http://localhost:7001/selenium/TestRunner.html?test=andy/TestSuite-andy.html and wanted to include a file (with a relative path name) that is also in the andy directory.

Patch can be found here: http://wiki.openqa.org/download/attachments/283/subdir.patch

Enjoy

I have attached a new version of selenium.

• It integrates all the patches listed above.
• you can include tests with a complete http url (say http://localhost:8000/selenium/tests/myTest.html)
• works with selenium IDE in 'play in selenium runner' mode (see above)

I attached a new 1.3 version with new tests that pass in selenium core 0.7 (previous tests came across a weird bug that could be avoided simplifying the test)

The include extension is working great on Firefox.  But it fails with IE.  When executed in Test Runner, the commands in the included file are lost; I only see two columns, which contain the target and value. 

The error message is: 'currentTest.currentRow.cells.2' is null or not an object

Any workaround for this? 

I'm having the same problem (include don't work in IE).

Searching for solution, but no results for now.

 2 Sandy Demi: Please if you will found solution - post it here. thanx.

The changes in this portion of the code work for me.  I'm sure the code could be improved, but I don't have time right now...

// first element is empty -> j=1
                // sdemi: changed j=1 to j=0 to insert command in first column
                for (var j = 0 ; j < testCols.length; j++)
                {
                    var newCol = testDocument.createElement("td")
                    var colText = testCols[j]
                    newCol = targetRow.appendChild(newCol)
                    newCol.innerHTML = colText
                }

                // sdemi: if row has only 2 columns, add empty third column
		if (testCols.length < 3)
		{
                    var newCol = testDocument.createElement("td")
                    var colText = testCols[j]
                    newCol = targetRow.appendChild(newCol)
                    newCol.innerHTML = ""
                }

        try
           

Hello all,

Hey guys, gone through the Selenium RC and found a really nice tool.

Well I have a small doubt. I want to do data driven test for my web application.

I tried the below following steps:

In my script, I added manually the data using store command and executed it worked fine.

Now what I want is if I have more than 1000 record, do i need to store all the 1000 records in my script? I hope this is disgusting... Well I should not... Can you please let me know how do I call all the 1000 records from a file (include and CSV). Please give me a bullet example.

Thanks,

Raja (From TP)

Hi,

I have version 1.3 of include, in Selenium IDE I'm geting such error message:

[info] Executing: |include | http://localhost:8080/selenium/tests/helpRegisterUser.html | email=new1@register.com,nickname=new1 |
[error] Unexpected Exception: message -> testDocument not avalaible., fileName -> file:///C:/work/projects/mindmatcher/v0.1/friendswebapp/resources/selenium/scripts/user-extensions.js, lineNumber -> 87, stack -> Error("testDocument not avalaible.")@:0 ("http://localhost:8080/selenium/tests/helpRegisterUser.html","email=new1@register.com,nickname=new1")@file:///C:/work/projects/mindmatcher/v0.1/friendswebapp/resources/selenium/scripts/user-extensions.js:87 call([object Object],"http://localhost:8080/selenium/tests/helpRegisterUser.html","email=new1@register.com,nickname=new1")@:0 ([object Object],[object Object])@chrome://selenium-ide/content/selenium/scripts/selenium-commandhandlers.js:306 ()@chrome://selenium-ide/content/selenium/scripts/selenium-executionloop.js:107 ()@chrome://selenium-ide/content/selenium/scripts/selenium-executionloop.js:78 @chrome://selenium-ide/content/selenium/scripts/selenium-executionloop.js:68 , name -> Error
 I tried to look at the line 87, and then at special future for IDE (document.URL.match(/^chrome:/))
 Unfortunately - no results
Someone knows what the problem can be?

Best regards
Konrad 

Hi,

I'm a little bit confused. Following the comments i had the idea that this extension works also for Selenium IDE, but then i tried it and it didn't work (similar error as the comment before). Can somebody guide me in this? Can I use this in IDE and if yes, why would the error be? It looked like the source path error, but i've tried everything, still no satisfying results.

 Thanks in advance,

Yelena 

Does anyone know when this extentions will be fixed to work with the new Selenium 0.8.0?

This is a quick fix. For me it works. I am not sure if this is the right solution.

I made the following changes to get this extension work with selenium 0.8.0:

user-extensions.js.sample (the include extension):
replace:

testDocument = getIframeDocument(getTestFrame())

with:

testDocument = testFrame.getDocument()

root cause:
the function getIframeDocument() has been removed from selenium-core (selenium-testrunner.js)

Robert

The fix I posted is incomplete.

My previous post fixes loading of the tests, but selenium skips the included test rows from execution.

I'll try to find the cause and after that a possible solution for that.

Robert

yeah i tried that too and ran into the same problem. I stopped looking after that.

To get the included rows executed in selenium 0.8.0 use following patch.
Make sure to apply the change I previously posted first.

Only tested with firefox 1.5

-            newRows.push(newRow)
+            //(rz WEB.DE) changed to work with selenium 0.8.0
+            newRows.push(new HtmlTestCaseRow(newRow))
         }
         // for selenium > 0.6
         try
         {
-            currentTest.commandRows = newRows.concat(currentTest.commandRows)
+            //(rz WEB.DE) changed to work with selenium 0.8.0
+            // Leave previously run commands as they are
+            seleniumCmdRowsPrev = currentTest.htmlTestCase.commandRows.slice(0, currentTest.htmlTestCase.nextCommandRowIndex)
+            seleniumCmdRowsNext = currentTest.htmlTestCase.commandRows.slice(currentTest.htmlTestCase.nextCommandRowIndex)
+            newCommandRows = seleniumCmdRowsPrev.concat(newRows)
+
+            // New commandRows with the included ones
+            currentTest.htmlTestCase.commandRows = newCommandRows.concat(seleniumCmdRowsNext)

hi, I have applied both the patches mentioned in the thread and when I run the test through TestRunner it is giving:

1. debug: Command found, going to execute include

1. error: Unexpected Exception: message -> Error while fetching file://H:/Regression%20Testing/includeCommand/SeleniumSampleTest-1.html server response has status = 0, , fileName -> file:///H:/Regression%20Testing/includeCommand/user-extensions.js, lineNumber -> 152, stack -> Error("Error while fetching file://H:/Regression%20Testing/includeCommand/SeleniumSampleTest-1.html server response has status = 0, ")@:0 ("SeleniumSampleTest-1.html","")@file:///H:/Regression%20Testing/includeCommand/user-extensions.js:152 call([object Object],"SeleniumSampleTest-1.html","")@:0 ([object Object],[object Object])@chrome://selenium-ide/content/selenium/scripts/selenium-commandhandlers.js:296 ()@chrome://selenium-ide/content/selenium/scripts/selenium-executionloop.js:110 (21)@chrome://selenium-ide/content/selenium/scripts/selenium-executionloop.js:78 apply([object Object],[object Array])@:0 (21)@chrome://selenium-ide/content/selenium/lib/prototype.js:48 @:0 , name -> Error

1. warn: currentTest.recordFailure: Selenium failure. Please report to selenium-dev@openqa.org, with error details from the log window. The error message is: Error while fetching file://H:/Regression%20Testing/includeCommand/SeleniumSampleTest-1.html server response has status = 0,

I used the BaseUrl: file://H:/Regression Testing/includeCommand/ and <td>include</td><td>SeleniumSampleTest-1.html</td> in my master script

Please let me know how to solve this error, is it a problem with the extension or the way in which I approach it???

Thanks & regards,
Rajesh

include user-extension worked when I hosted my selenium scripts in a server, which I'm calling from my master script. Then in my master test script where I call my hosted script using include cmd which accepts only the HTTP request as of now, like
http://localhost:8080/Selenium/testscript.html

I would like to know, how we can use include extension to fetch the script from the local disk using file:/// protocol???? I beleive in this case we have to modify the include user extension to accept the request from generic protocol.

Anyone working on this, please do share your knowledge on the same...

Thanks & regards,
Rajesh

Solution to use include with file://

replace:
if ( requester.status != 200 )

with:
if ( requester.status != 200 && requester.status != 0 )

Robert

I am currently refactoring the include command to:

• be easier to maintain
• work in IE (currently an complex xpath will cause IE to hang in an busy loop)
• use as many fixes posted here as I am aware of
• use more selenium functionality and so do less by it's own
• ... and more

Someone interested in this work?

I would package an, say "includeCommand_2_0.zip"

Is there interest in updates to include?

Does the original author (alex?) agree with that?

Robert

Really happy if you do this work. I personally don't have the time to work on it.
Thanks
Alex

Hi, We are currently using Selenium Core 0.8.1 on our project. Is anyone working on tweaking the user-extension.js file to make the include command work on Selenium Core 0.8.1?
Also, it would be awesome if its tweaked to work on IE.
Robert seems to be working on refactoring the include command. I am curious to know as to how far have you got with the refactoring.

Vijay

As always I am short of time to work on the include command 2.0

I will try to block some time today to package and upload the current work, which contains many fixes.

sorry for the delay

robert

I have attached a raw user-extensions.js (named user-extensions.js.includeCommand_2_0_alpha) wich should contain all fixes posted previously.

It should work in IE, though I have some problems with the file protocol in IE.

As soon as I have a little more time for this I will package a fully zip.

Also it works with selenium 0.8.0 and 0.8.1

It does not work with seleniumRC and I did not test it with seleniumIDE

robert

Thanks for the good work!

Andras

I've just attached version 2.1 of includeCommand as a full zip.

since 2.0-alpha there are a some new fixes mainly in constructing urls.

take a look at the tests for more examples (and most of the fixes/enhances)

the testsuite is adjusted to run with selenium 0.8.2

• I have left (commented out) the old open-urls to run it with previous releases of selenium

tested with firefox 1.5.08 and firefox 2.0

Not (yet) tested:

• IE and other user-agents
• seleniumRC nor seleniumIDE - though the fixes in constructing urls are to get this working

note: I changed the naming after inclusion, to be able to re-run already run tests

• -included changed to includeExpanded
• +included to includeCollapsed

robert

Hi. Fooling around with using include 2.1 with IDE without immediate luck. I did notice that the fix mentioned above to get file:/// protocol working (http://wiki.openqa.org/display/SEL/include?focusedCommentId=1425#comment-1425) has a typo in the .js file on line 292; "!=="

When I fix that, it doesn't quite work but I get the refactoring work in progress warn from rz. It'd rock to be able to use this extension with IDE and the file:/// protocol.

"!==" is not an typo, read this for details: http://developer.mozilla.org/en/docs/Core_JavaScript_1.5_Reference:Operators:Comparison_Operators

Could You give me more details what is not working?

Testing include with seleniumIDE (and other like seleniumRC) is still on my todo list.

Ah... I'm not a Javascript person and didn't know about the strict equals. It was a strange assumption for to make that this was a typo, I should have paid closer attention.

When running a script with the include command from the chrome testrunner, I get:

warn currentTest.recordFailure: Selenium failure. Please report to selenium-dev@openqa.org, with error details from the log window. The error message is: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) nsIXMLHttpRequest.send

IDE also doesn't show/hide, and complains about user-extensions.js. Unfortunately I can't post much of the log output on this wiki without it getting really garbled, but if you want I could send it to you in a different medium.

Could You post the url your are using with include?
and if it is relative the base url you are using in seleniumIDE?

The message from above is from using

chrome://selenium-ide/content/selenium/TestRunner.html?baseURL=http://localhost&test=file:///c:/selenium/includeCommand_2_1/tests/includecommand/testsuite.html&userExtensionsURL=file:///c:/selenium/includeCommand_2_1/user-extensions.js&auto=true

The test file and the user-extensions.js are the ones from the zip. I don't know what you mean about the relative url in IDE

ok, i see.
there are a couple of bugs in handling urls with the chrome protocol.

as a workaround you could change your url slightly to get it work:

chrome://selenium-ide/content/selenium/TestRunner.html?test=file:///c:/selenium/includeCommand_2_1/tests/includecommand/testsuite.html&baseURL=file:///c:/selenium/includeCommand_2_1/tests/&userExtensionsURL=file:///c:/selenium/includeCommand_2_1/user-extensions.js&auto=true

does this work for you?

the bugs are in handling the baseUrl:
1. baseUrl is not expected to be the first call-parameter
2. baseUrl is expected to end with a slash ("/")

i think not a bug is:

• baseUrl has to point to the directory containing TestSuite.html

thanks for reporting

correction: the explanation is right, but the expample url is not:

chrome://selenium-ide/content/selenium/TestRunner.html?test=file:///c:/selenium/includeCommand_2_1/tests/includecommand/testsuite.html&baseURL=file:///c:/selenium/includeCommand_2_1/tests/includeCommand/&userExtensionsURL=file:///c:/selenium/includeCommand_2_1/user-extensions.js&auto=true

so now: does this work for you?

Haha. That does work. Thanks for the explanation.

Version 2.1 is not working correctly for me with IE (v6.0). I have 'open' commands in my include file that are ignored during execution. (They were executed with the old include extension.)

Hello Sandy,

Could You post exapmles, so I can reproduce this problem?

Sure. I have a setup.html file that I include at at the beginning of every test, similar to the following:

When I run my test, the included rows appear, but the 'open' commands are not executed. The rows remain white in the test table, and there are no 'info: Executing: | open | ...' calls logged to the console.

After looking at this again, I see that the setTimeout command is not executed either. Maybe the 2-column rows aren't getting added to the execution stack?

Maybe the 2-column rows aren't getting added to the execution stack?

Yes, that's a selenium feature.
Only rows with at least 3 columns are treated as selenium commands.

I don't get it. Are you saying that 'setTimeout' and 'open' are not selenium commands?

All of the rows in my included file (setup.html) are executed in Firefox. It's only in IE that the 2-column rows are not executed.

I don't know why it is only in IE in your case.
But any row less than 3 columns is treated as an comment by selenium, so does include.

Did you try it with all rows having 3 columns?

Which selenium version are you using?

I'm using SC 0.8.2.
I think I caused some confusion by saying that the row has 2 columns. The HTML table row does have 3 columns, but it only has values in the first 2:
<tr>
<td>setTimeout</td>
<td>60000</td>
<td></td>
</tr>

I tried putting a dummy value in the 3rd column (even though the setTimeout command doesn't require a value in the 3rd column):
<tr>
<td>setTimeout</td>
<td>60000</td>
<td>blah</td>
</tr>

In this case, the included row is executed correctly on IE. So with IE, included files that contain a 3-column row with an empty 3rd column treat the row as if it only had 2 columns. Weird.

It seems that IE removes empty table columns.

I recommend putting an &nbsp; in empty columns.

Tried the Chrome URL noted above for running a script with and include statement in IDE testrunner but get an "Unknown command: 'include'" error. I set the Selenium Core Extensions setting to point the the appropriate include_command user-extensions.js file.

What am I missing, is there some other configuration needed to get include_command to work with the IDE?

If You get an "Unknown command" your path to or the user-extension.js itself seems to be wrong.

Did You check the paths and the user-extension.js?

Should I have the include_command js listed in the IDAE's options\Selenium Core path? Interestingly, I get an error when starting the IDE "Failed to load user-extensions.js! files=... error=ReferenceError: HtmlRunner TestLoop is not defined"

The path and file are valid as the extension does work when using Selenium core.

OK, I see

The include Command is not designed to work inside the IDE, as include uses the HTMLTestRunner to inject the included rows.
However the HTMLTestRunner is not available inside the IDE.

SO IF THE &BASEURL HAS TO BE A FILE HOW CAN I RUN THE TEST ON A REMOTE SERVER?

The baseURL does not have to be a file. Can also be http.

I am getting a 404 error. The calling and called scripts are in the same directory. The error is:

Selenium failure. Please report to selenium-dev@openqa.org, with error details from the log window. The error message is: Error while fetching http://10.77.62.197:83/selenium/core//ctc-selenium/tests/logon.html server response has status = 404, Not Found

The calling script has:
<table><tr><td>include</td><td>logon.html</td><td>userid=TEST01,password=TestPW01,username=TEST USER</td></tr></table>

The contents of the dir are:
/tandem/web_applications/ctc/ctc83/webserver/root/ctc-selenium/tests: ls -ltr
total 108
rw-rw-rw 1 SUPER.WEBMASTR SUPER 6315 Dec 5 18:09 TestUserMaintenance.html
rw-rw-rw 1 SUPER.WEBMASTR SUPER 7790 Dec 6 15:31 TestSecurityMaintenance.html
rw-rw-rw 1 SUPER.WEBMASTR SUPER 6957 Dec 21 20:26 TestSimulationEnvironment.html
rw-rw-rw 1 SUPER.WEBMASTR SUPER 4806 Jan 2 16:34 TestUploadFiles.html
rw-rw-rw 1 SUPER.WEBMASTR SUPER 3483 Jan 2 20:59 TestAutoScriptSetup.html
rw-rw-rw 1 SUPER.WEBMASTR SUPER 3984 Jan 9 17:11 TestSystemManager-ExtSystemMgmt.html
rw-rw-rw 1 SUPER.WEBMASTR SUPER 7360 Jan 16 17:18 TestManualScriptSetup.html
rw-rw-rw 1 SUPER.WEBMASTR SUPER 2239 Mar 14 17:44 TestIncorrectLogin.html
rw-rw-rw 1 SUPER.WEBMASTR SUPER 3838 Mar 14 18:41 TestSuite.html
rw-rw-rw 1 SUPER.WEBMASTR SUPER 2835 Mar 14 20:30 TestAddUser.html
drwxrwxrwx 1 SUPER.WEBMASTR SUPER 4096 Mar 16 15:20 snippets
rw-rw-rw 1 SUPER.WEBMASTR SUPER 647 Mar 16 15:25 logon.html
rw-rw-rw 1 SUPER.WEBMASTR SUPER 640 Mar 16 15:26 TestLogin-LogoutFunctions.html

The calling page is:
http://10.77.62.197:83/selenium/core/TestRunner.html?test=%2Fctc-selenium%2Ftests%2FTestSuite.html&multiWindow=on&resultsUrl=..%2FpostResults

Any clues?
TIA

if you are using includeCommand_2_1 then have a look at the log window.
include command should write the url it is using to get the tests to include.
is this url correct?

It appears the constructed url has a double slash notice selenium/core//ctc-tests...
If I put in absolute url that works but I have other issues (will add as a separate comment to keep things clean)

debug: IncludeCommand: include URL seems to be relative determined baseUrl='http://10.77.62.197:83/selenium/core/'
debug: IncludeCommand: using url to get include document='http://10.77.62.197:83/selenium/core//ctc-selenium/tests/logon.html'
error: Unexpected Exception: Error while fetching http://10.77.62.197:83/selenium/core//ctc-selenium/tests/logon.html server response has status = 404, Not Found
error: Exception details: name -> Error, description -> Error while fetching http://10.77.62.197:83/selenium/core//ctc-selenium/tests/logon.html server response has status = 404, Not Found, message -> Error while fetching http://10.77.62.197:83/selenium/core//ctc-selenium/tests/logon.html server response has status = 404, Not Found
warn: currentTest.recordFailure: Selenium failure. Please report to selenium-dev@openqa.org, with error details from the log window. The error message is: Error while fetching http://10.77.62.197:83/selenium/core//ctc-selenium/tests/logon.html server response has status =